My perspective, based on my personal opinions and admitted biases ...
Pros:
- she's incredibly talented; a great entertainer, writer, performer, musician, etc
- she's very generous with her money, obviously
- she's reportedly polite to everyone, as far as we can tell
Cons:
- she's fake; she claims "country" roots, but actually grew up in suburbia in PA
- she's very anti-2A
- she's not the role model now that she was when she was younger (young girls emulate what they see, and Swift has "matured" into a much more provocative performer). She's not a skank by any means, but she's not as wholesome as she was, either
My daughter is a Swifty; I've had to tolerate her music for more than a decade. Now that my daughter is out of the house, it's no longer a problem because it's no longer played in my house, my truck or my life.