Jeep oil pumps have about 150K +/- lifespan, which you have exceeded (based on experience with Jeeps, friends, + clubs). I think you'll be fine with the new pump. On my '92 Wrangler trail rig (2.5L), I Tee'd a mechanical gauge in with the factory one. There is a difference. In the very least, hook up only the mechanical gauge and see what the pressure is after 10 minutes of driving. Jeep factory oil pressure gauges aren't the best.
I would also try running a tank of 93 gas to help that knock if it persists after the oil pump install. Carbed 258's don't distribute fuel as evenly as EFI, so cylinder 1 + 6 may run leaner than ther others. That BBD carb probably doesn't help matters, but if it runs OK, then leave it. I really wish I had video of my friends Jeep. As the 93 gas displaced the old fuel in the float bowl, you could hear the knock go away. It was truly amazing.
Regarding your filter, I forgot the 258's used the metric one (A Fram PH3985 equivalent) and not a FL300.
BTW, while you're in there, you might as well replace the rear main. It' cheap and easy. I also highly recommend the Felpro one-piece rubberized oil pan gasket. It has the torque rings at each bolt hole. It's awesome. I have done about 8-9 rear main seals on 258's, 4.0L's, and my 2.5L. Not one leak a drop of oil. This gasket alone cuts your repair time.
Let us know how you make out. Good luck.
*We need a Jeep wave icon*